Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes PHPCS issues for phpstan v12.4 #1085

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

kedarkhaire
Copy link
Collaborator

PHPCS fix includes the following fixes

  1. Use statement sort in alphabetically order
  2. Parameter has null default value, but is not marked as nullable.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.97%. Comparing base (34bef3f) to head (62a5d29).
Report is 1 commits behind head on 3.x.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #1085      +/-   ##
============================================
- Coverage     44.20%   42.97%   -1.23%     
  Complexity     3041     3041              
============================================
  Files           342      342              
  Lines         11110    11110              
============================================
- Hits           4911     4775     -136     
- Misses         6199     6335     +136     

see 22 files with indirect coverage changes

@kedarkhaire
Copy link
Collaborator Author

Commands used to analyze and fix the PHPCS issues

  1. Fix code style issues & apply automatic code style fixes with PHPCBF.
    vendor/bin/phpcbf --standard=web/modules/contrib/apigee_edge/phpcs.xml.dist web/modules/contrib/apigee_edge -s --colors

  2. Check remaining code style issues with PHPCS and fix them manually.
    vendor/bin/phpcs --standard=web/modules/contrib/apigee_edge/phpcs.xml.dist web/modules/contrib/apigee_edge -p -s -n --colors

Thanks!

Copy link
Collaborator

@shishir-intelli shishir-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kedarkhaire kedarkhaire self-assigned this Oct 1, 2024
@shishir-intelli shishir-intelli merged commit 48b7e83 into apigee:3.x Oct 1, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants