Fix error while creating select field in D10.2 and removed the unnecessary patch 3042467-50.patch #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssary patch 3042467-50.patch
shishir-intelli
added a commit
to shishir-intelli/devportal-kickstart-project-composer
that referenced
this pull request
Aug 23, 2024
Remove unnecessary patch `Fix for TypeError: FieldTypePluginManager::createFieldItem() called in FieldStorageConfig.php":"https://www.drupal.org/files/issues/2024-05-27/field-typeerror-3450175-3.patch` The actual issue is resolved here apigee/apigee-edge-drupal#1076 so we do not need this patch.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.x #1076 +/- ##
=========================================
Coverage 44.40% 44.40%
Complexity 3041 3041
=========================================
Files 342 342
Lines 11110 11110
=========================================
Hits 4933 4933
Misses 6177 6177 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1075
This PR removes the unnecessary patch added in workflow and resolves the error issue by throwing
InvalidArgumentExceptionexception instead ofreturn NULL;