-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding validation for email-id field #1050
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxr576
reviewed
Apr 11, 2024
giteshk
reviewed
Apr 16, 2024
src/Plugin/Validation/Constraint/LowercaseEmailConstraintValidator.php
Outdated
Show resolved
Hide resolved
mxr576
reviewed
Apr 16, 2024
src/Plugin/Validation/Constraint/LowercaseEmailConstraintValidator.php
Outdated
Show resolved
Hide resolved
src/Plugin/Validation/Constraint/LowercaseEmailConstraintValidator.php
Outdated
Show resolved
Hide resolved
src/Plugin/Validation/Constraint/LowercaseEmailConstraintValidator.php
Outdated
Show resolved
Hide resolved
src/Plugin/Validation/Constraint/LowercaseEmailConstraintValidator.php
Outdated
Show resolved
Hide resolved
mxr576
reviewed
Apr 24, 2024
mxr576
reviewed
Apr 24, 2024
mxr576
reviewed
Apr 24, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.x #1050 +/- ##
=============================================
+ Coverage 27.96% 44.33% +16.36%
Complexity 3033 3033
=============================================
Files 341 341
Lines 11094 11094
=============================================
+ Hits 3102 4918 +1816
+ Misses 7992 6176 -1816 |
shishir-intelli
approved these changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #730
For Hybrid instance (Org type = ApigeeX),
add field validation for user email field on all operations. Validation will be to check the string is in lowercase.
Should be triggered on new user creation, user edit, login, SAML auth, drupal default login & LDAP login.