Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding validation for email-id field #1050

Merged
merged 16 commits into from
May 9, 2024

Conversation

kedarkhaire
Copy link
Collaborator

Fixes #730
For Hybrid instance (Org type = ApigeeX),
add field validation for user email field on all operations. Validation will be to check the string is in lowercase.
Should be triggered on new user creation, user edit, login, SAML auth, drupal default login & LDAP login.

@kedarkhaire kedarkhaire marked this pull request as draft April 11, 2024 11:53
@kedarkhaire kedarkhaire added this to the 3.0.7 milestone Apr 11, 2024
@kedarkhaire kedarkhaire added the enhancement New feature or request label Apr 11, 2024
apigee_edge.module Outdated Show resolved Hide resolved
@kedarkhaire kedarkhaire marked this pull request as ready for review April 12, 2024 13:25
src/CliService.php Outdated Show resolved Hide resolved
apigee_edge.module Outdated Show resolved Hide resolved
apigee_edge.module Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.33%. Comparing base (c797843) to head (2b60f5d).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##                3.x    #1050       +/-   ##
=============================================
+ Coverage     27.96%   44.33%   +16.36%     
  Complexity     3033     3033               
=============================================
  Files           341      341               
  Lines         11094    11094               
=============================================
+ Hits           3102     4918     +1816     
+ Misses         7992     6176     -1816     

see 117 files with indirect coverage changes

Copy link
Collaborator

@shishir-intelli shishir-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error sending email with capitalization to Apigee.
4 participants