Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements for adding filter with ChannelId on condition #1001

Merged
merged 7 commits into from
Dec 5, 2023
Merged

Enhancements for adding filter with ChannelId on condition #1001

merged 7 commits into from
Dec 5, 2023

Conversation

kedarkhaire
Copy link
Collaborator

@kedarkhaire kedarkhaire commented Dec 4, 2023 •
edited
Loading

Fixes #947

@kedarkhaire kedarkhaire added this to the 2.1.3 milestone Dec 4, 2023
@kedarkhaire kedarkhaire added enhancement New feature or request deprecation labels Dec 4, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2023 •
edited
Loading

Codecov Report

Merging #1001 (0e8a02b) into 2.x (c164633) will increase coverage by 18.41%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##                2.x    #1001       +/-   ##
=============================================
+ Coverage     26.53%   44.95%   +18.41%     
  Complexity     3040     3040               
=============================================
  Files           345      345               
  Lines         11153    11153               
=============================================
+ Hits           2960     5014     +2054     
+ Misses         8193     6139     -2054
Files Coverage Δ
...dge_teams/src/Entity/Controller/TeamController.php 89.47% <ø> (+7.89%) ⬆️
...dules/apigee_edge_teams/src/Form/TeamAliasForm.php 0.00% <0.00%> (ø)

... and 125 files with indirect coverage changes

@kedarkhaire kedarkhaire changed the title Enhancements for adding filter with ChannelId on condition and solving PHP8.2 deprecation of dynamic variables Enhancements for adding filter with ChannelId on condition Dec 5, 2023
shishir-intelli
shishir-intelli approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@shishir-intelli shishir-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kedarkhaire kedarkhaire merged commit 374230e into apigee:2.x Dec 5, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shishir-intelli shishir-intelli shishir-intelli approved these changes

@giteshk giteshk Awaiting requested review from giteshk

@divya-intelli divya-intelli Awaiting requested review from divya-intelli

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
2.1.3
Development

Successfully merging this pull request may close these issues.
2 participants
@kedarkhaire @shishir-intelli