Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved the validation for monitized enabled org for enabling teams for ApigeeX and edge for 2x #1000

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

shishir-intelli
Copy link
Collaborator

@shishir-intelli shishir-intelli commented Dec 4, 2023

Closes #936 for 2x branch
Resolved the dead code for validating for Apigee X with Monetization enabled org while enabling Teams module,
also added error message on all Teams related pages if the module is already enabled (In case organisation switched from Edge to X).

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Merging #1000 (c26d95c) into 2.x (d319a51) will increase coverage by 1.07%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #1000      +/-   ##
============================================
+ Coverage     43.91%   44.99%   +1.07%     
  Complexity     3027     3027              
============================================
  Files           344      344              
  Lines         11138    11138              
============================================
+ Hits           4891     5011     +120     
+ Misses         6247     6127     -120     

see 17 files with indirect coverage changes

Copy link
Collaborator

@kedarkhaire kedarkhaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shishir-intelli shishir-intelli merged commit 2b3d913 into apigee:2.x Dec 5, 2023
5 checks passed
@shishir-intelli shishir-intelli deleted the backport_936 branch January 11, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants