Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Visibility by Access" - Visibility attribute for API product not enforced correctly #392

Closed
mikesson opened this issue Mar 25, 2020 · 0 comments · Fixed by #394
Closed
Assignees
Milestone

Comments

@mikesson
Copy link

I'm using the "visibility by access" capability in Edge > API products to control API product visibility through the internal/private/public attribute in Edge. This applies to an API which isn't part of a Product Bundle/Rate Plan (as using w/ monetization modules enabled), yet it's still showing up even though set to internal. Any ideas what could be missing / is it a bug?

Steps to reproduce: Create an API product with visibility set to Internal or Private, and leave those unchecked in the Apigee Edge > API products section. Then log in as an authenticated user, and create new app, and check if API product is visible from the list.

image (14)

@cnovak cnovak transferred this issue from apigee/apigee-edge-drupal Mar 30, 2020
@cnovak cnovak transferred this issue from apigee/apigee-m10n-drupal Mar 30, 2020
@cnovak cnovak self-assigned this Mar 31, 2020
@arunz6161 arunz6161 added this to the 8.x-1.8 milestone Mar 31, 2020
arlina-espinoza pushed a commit that referenced this issue Mar 31, 2020
…orrectly

The Apigee M10n module’s hook_ENTITY_TYPE_access uses the Apigee Monetization API to determine an API Product ‘assign’ access by calling `/developers/{developer}/eligible-products`, which returns AccessResult::allowed for all API products.

This API returns all API Products
1. That are able to be assigned to an App because the developer purchased a Rate plan that contains the API product
2. All API products that are not monetized.

Due to #2, the Apigee Edge module hook_ENTITY_TYPE_access needs to return AccessResult::forbidden when the operation is ‘assign’ and the user does not have the correct role to assign an API product to an app.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants