-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove dependency on drupal/adminimal_admin_toolbar for D10 comp… #666
fix: Remove dependency on drupal/adminimal_admin_toolbar for D10 comp… #666
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@sleepingmonk , please create a ticket with more description about this change. |
I think we should remove the dependency 'adminimal_admin_toolbar' module due to its support limitations, as it is only compatible with Drupal 8 and 9. Since Drupal 9 has reached its end of life, it would be prudent to explore alternatives. I recommend considering Admin Toolbar as a suitable replacement for 'adminimal_admin_toolbar' module. |
Hi @vpa24 , currently drupal/adminimal_admin_toolbar dev version is compatible with Drupal 10 and is automatically downloaded without any error. Could you help us in understanding how it is affecting in your project. |
Hi @divya-intelli, I successfully upgraded from Drupal 9 to Drupal 10 without any issues but in my opinion, the Admin Toolbar module is better than the 'adminimal_admin_toolbar' module. |
Thanks for the responses. The package does not require the -dev version and so blocks a D10 upgrade. I will require the dev version in my base composer.json as a work around, but it is just a work around, this module will not be enabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@sleepingmonk , thank you for the PR. |
…atibility.