Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove dependency on drupal/adminimal_admin_toolbar for D10 comp… #666

Merged

Conversation

sleepingmonk
Copy link
Contributor

…atibility.

Copy link

google-cla bot commented Nov 15, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@divya-intelli
Copy link
Collaborator

@sleepingmonk , please create a ticket with more description about this change.

@vpa24
Copy link
Contributor

vpa24 commented Nov 16, 2023

I think we should remove the dependency 'adminimal_admin_toolbar' module due to its support limitations, as it is only compatible with Drupal 8 and 9. Since Drupal 9 has reached its end of life, it would be prudent to explore alternatives. I recommend considering Admin Toolbar as a suitable replacement for 'adminimal_admin_toolbar' module.

@divya-intelli
Copy link
Collaborator

I think we should remove the dependency 'adminimal_admin_toolbar' module due to its support limitations, as it is only compatible with Drupal 8 and 9. Since Drupal 9 has reached its end of life, it would be prudent to explore alternatives. I recommend considering Admin Toolbar as a suitable replacement for 'adminimal_admin_toolbar' module.

Hi @vpa24 , currently drupal/adminimal_admin_toolbar dev version is compatible with Drupal 10 and is automatically downloaded without any error. Could you help us in understanding how it is affecting in your project.

@vpa24
Copy link
Contributor

vpa24 commented Nov 17, 2023

I think we should remove the dependency 'adminimal_admin_toolbar' module due to its support limitations, as it is only compatible with Drupal 8 and 9. Since Drupal 9 has reached its end of life, it would be prudent to explore alternatives. I recommend considering Admin Toolbar as a suitable replacement for 'adminimal_admin_toolbar' module.

Hi @vpa24 , currently drupal/adminimal_admin_toolbar dev version is compatible with Drupal 10 and is automatically downloaded without any error. Could you help us in understanding how it is affecting in your project.

Hi @divya-intelli, I successfully upgraded from Drupal 9 to Drupal 10 without any issues but in my opinion, the Admin Toolbar module is better than the 'adminimal_admin_toolbar' module.

@sleepingmonk
Copy link
Contributor Author

Thanks for the responses.

The package does not require the -dev version and so blocks a D10 upgrade.
Support for the adminimal_admin_toolbar module is not great.
I believe this adminimal_admin_toolbar is outdated given the current Drupal ecosystem.
I don't believe the apigee-devportal-kickstart package should be opinionated about which toolbar we should be using.

I will require the dev version in my base composer.json as a work around, but it is just a work around, this module will not be enabled.

Copy link
Collaborator

@divya-intelli divya-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@divya-intelli
Copy link
Collaborator

@sleepingmonk , thank you for the PR.

@divya-intelli divya-intelli merged commit 344d920 into apigee:2.x Nov 22, 2023
5 checks passed
@divya-intelli divya-intelli added this to the 3.0.0 milestone Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants