Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRUP-662 Keep original start date property can be null #49

Merged
merged 2 commits into from
May 6, 2019
Merged

DRUP-662 Keep original start date property can be null #49

merged 2 commits into from
May 6, 2019

Conversation

mxr576
Copy link
Contributor

@mxr576 mxr576 commented Mar 27, 2019 •
edited
Loading

Related issue: #47

This PR closes #48 #52.

@mxr576
Keep original start date property can be null
0f85421 
in parentRatePlan response objects.

apigee#47
This was referenced Mar 27, 2019
Closed
Closed
@mxr576 mxr576 mentioned this pull request Apr 24, 2019
Closed
@mxr576 mxr576 changed the title [DO NOT MERGE] Keep original start date property can be null DRUP-662 Keep original start date property can be null Apr 29, 2019
@mxr576 mxr576 requested review from cnovak and Jaesin April 29, 2019 09:28
@mxr576 mxr576 marked this pull request as ready for review April 29, 2019 09:28
@codecov-io
Copy link

Codecov Report

Merging #49 into 2.x will decrease coverage by 0.06%.
The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x      #49      +/-   ##
============================================
- Coverage     91.52%   91.46%   -0.07%     
- Complexity     1553     1555       +2     
============================================
  Files           240      240              
  Lines          3033     3035       +2     
============================================
  Hits           2776     2776              
- Misses          257      259       +2
Impacted Files Coverage Δ Complexity Δ
...operty/KeepOriginalStartDatePropertyAwareTrait.php 66.66% <66.66%> (-33.34%) 4 <2> (+2)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b4b4c2...80c5940. Read the comment docs.

Jaesin
Jaesin approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@Jaesin Jaesin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think it would be a good idea to mark isKeepOriginalStartDate as deprecated.

@mxr576 mxr576 merged commit edfda4b into apigee:2.x May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaesin Jaesin Jaesin approved these changes

@cnovak cnovak Awaiting requested review from cnovak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mxr576 @codecov-io @Jaesin