-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove symfony/serializer conflict and bump version #376
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.x #376 +/- ##
============================================
- Coverage 87.61% 86.81% -0.80%
- Complexity 1754 1768 +14
============================================
Files 349 349
Lines 4601 4643 +42
============================================
Hits 4031 4031
- Misses 570 612 +42
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #373
In
symfony/serializer:>6.4.6
prevents the attributes' values from being read if the attribute setters are not implemented.
Ref : https://github.com/symfony/symfony/blob/5df912c9786c53f413c2604b3f979461a36486c5/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php#L312
Now, we added setters for attributes that were previously not included because of this
https://github.com/symfony/property-access/blob/v4.2.5/PropertyAccessor.php#L433-L435