Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove symfony/serializer conflict and bump version #376

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

shishir-intelli
Copy link
Collaborator

Closes #373

In symfony/serializer:>6.4.6

$context['_read_attributes'] = false;

prevents the attributes' values from being read if the attribute setters are not implemented.
Ref : https://github.com/symfony/symfony/blob/5df912c9786c53f413c2604b3f979461a36486c5/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php#L312

Now, we added setters for attributes that were previously not included because of this
https://github.com/symfony/property-access/blob/v4.2.5/PropertyAccessor.php#L433-L435

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 26.19048% with 31 lines in your changes missing coverage. Please review.

Project coverage is 86.81%. Comparing base (04d36d2) to head (394f7ff).
Report is 1 commits behind head on 3.x.

Files with missing lines Patch % Lines
...on/Structure/Reports/Criteria/AbstractCriteria.php 25.00% 27 Missing ⚠️
...tructure/Reports/Criteria/GroupByCriteriaTrait.php 33.33% 2 Missing ⚠️
...Reports/Criteria/TransactionTypesCriteriaTrait.php 33.33% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x     #376      +/-   ##
============================================
- Coverage     87.61%   86.81%   -0.80%     
- Complexity     1754     1768      +14     
============================================
  Files           349      349              
  Lines          4601     4643      +42     
============================================
  Hits           4031     4031              
- Misses          570      612      +42     
Flag Coverage Δ
unittests 86.81% <26.19%> (-0.80%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...tructure/Reports/Criteria/GroupByCriteriaTrait.php 62.50% <33.33%> (-37.50%) ⬇️
...Reports/Criteria/TransactionTypesCriteriaTrait.php 62.50% <33.33%> (-37.50%) ⬇️
...on/Structure/Reports/Criteria/AbstractCriteria.php 53.12% <25.00%> (-31.88%) ⬇️

Copy link
Collaborator

@kedarkhaire kedarkhaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shishir-intelli shishir-intelli merged commit f0271ea into apigee:3.x Sep 13, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

Unable to install 3.0.6 on Drupal 10.3.2 or on any version that requires symfony/serializer:>6.4.6
3 participants