Support assigning API products to Apps on creation #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from apigee repo
mxr576
reviewed
Mar 6, 2023
mxr576
reviewed
Mar 6, 2023
mxr576
reviewed
Mar 6, 2023
giteshk
approved these changes
Mar 9, 2023
|
Sorry, but I still have concerns with this design change that are not answered yet |
Codecov Report
@@ Coverage Diff @@
## 2.x #248 +/- ##
============================================
+ Coverage 89.01% 89.16% +0.14%
- Complexity 1646 1649 +3
============================================
Files 334 330 -4
Lines 4379 4374 -5
============================================
+ Hits 3898 3900 +2
+ Misses 481 474 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mxr576
reviewed
Mar 10, 2023
src/Api/Management/Entity/App.php
Outdated
| if (!$this->appId) { | ||
| $this->initialApiProducts = $initialApiProducts; | ||
| } else { | ||
| throw new \Exception('This method is only supported for creating a new app.'); |
There was a problem hiding this comment.
Should be a \LogicException() since calling it is a "mistake made by the developer".
(Although we know this method should only exist on New app entities for which we do not have an object type...)
There was a problem hiding this comment.
This has been taken care. Thank you for pointing it out.
|
Thanks. What about adding test coverage? |
mxr576
reviewed
Mar 10, 2023
giteshk
pushed a commit
to giteshk-org/apigee-client-php
that referenced
this pull request
Mar 24, 2023
giteshk
added a commit
that referenced
this pull request
Mar 24, 2023
* Support assigning API products to Apps on creation (#248) * Bump version to 2.0.19 and change log (#250) --------- Co-authored-by: phdhiren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #214