Drop support of HTTPlug 1.x #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxr576
commented
Oct 12, 2020
| "php-http/client-implementation": "^1.0", | ||
| "php-http/discovery": "^1.0", | ||
| "php-http/httplug": "^1.1", | ||
| "php-http/discovery": "^1.6.0", |
There was a problem hiding this comment.
mxr576
commented
Oct 12, 2020
| "php-http/message": "^1.0", | ||
| "php-http/message-factory": "^1.0", | ||
| "phpdocumentor/reflection-docblock": "^3.0 || ^4.0", | ||
| "psr/http-message": "^1.0", | ||
| "symfony/options-resolver": "^3.4 || ^4.0", | ||
| "symfony/property-access": "^3.4 || ^4.0", | ||
| "symfony/property-access": "^3.4.41 || ^4.4.9", |
There was a problem hiding this comment.
Because symfony/property-access@e1a6c91
|
@arshad @arlina-espinoza @cnovak hi, may I get a review on this? These are old dependencies and having them here blocks upstream projects to depend on newer, supported versions if they would like to use them together with this library. |
arlina-espinoza
suggested changes
Nov 9, 2020
There was a problem hiding this comment.
@mxr576 When trying to install with the latest template for Kickstart (https://github.com/apigee/devportal-kickstart-project-composer/blob/8.x/composer.json), I get the following errors:
arlina@system76:/v/w/h/c/d9$ composer require apigee/apigee-client-php:"dev-issue/41 as 2.0.6" --update-with-dependencies
./composer.json has been updated
Loading composer repositories with package information Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.
Problem 1
- Conclusion: don't install apigee/apigee-client-php 2.0.6|remove php-http/guzzle6-adapter v1.1.1
- Conclusion: install apigee/apigee-client-php 2.0.6
- Conclusion: don't install php-http/httplug 2.2.0
- apigee/apigee-client-php 2.0.6 requires php-http/client-implementation ^1.0 -> satisfiable by php-http/guzzle6-adapter[v1.1.1].
- Conclusion: don't install php-http/guzzle6-adapter v1.1.1
- Conclusion: remove php-http/httplug v1.1.0
- Conclusion: don't install php-http/httplug 2.1.0
- Installation request for apigee/apigee-client-php dev-issue/41 as 2.0.6 -> satisfiable by apigee/apigee-client-php[dev-issue/41].
- Installation request for drupal/apigee_m10n (locked at 1.7.0, required as ^1.0.0) -> satisfiable by drupal/apigee_m10n[1.7.0].
- php-http/guzzle6-adapter v1.1.1 requires php-http/httplug ^1.0 -> satisfiable by php-http/httplug[v1.1.0, v1.0.0, v1.0.0-RC1, v1.0.0-alpha, v1.0.0-alpha2, v1.0.0-alpha3, v1.0.0-beta].
- Can only install one of: php-http/httplug[v1.1.0, 2.x-dev].
- Can only install one of: php-http/httplug[2.x-dev, v1.1.0].
- Can only install one of: php-http/httplug[v1.0.0, 2.x-dev].
- Can only install one of: php-http/httplug[v1.0.0-RC1, 2.x-dev].
- Can only install one of: php-http/httplug[v1.0.0-alpha, 2.x-dev].
- Can only install one of: php-http/httplug[v1.0.0-alpha2, 2.x-dev].
- Can only install one of: php-http/httplug[v1.0.0-alpha3, 2.x-dev].
- Can only install one of: php-http/httplug[v1.0.0-beta, 2.x-dev].
- apigee/apigee-client-php 2.0.6 requires php-http/httplug ^2.0 -> satisfiable by php-http/httplug[2.1.0, 2.2.0, 2.x-dev, v2.0.0].
- Conclusion: don't install php-http/httplug v2.0.0
Installation failed, reverting ./composer.json to its original content.Looking into what other dependencies are locking php-http/httplug to ^1.0, I find:
arlina@system76:/v/w/h/c/d9$ composer why php-http/httplug -t
php-http/httplug v1.1.0 HTTPlug, the HTTP client abstraction for PHP
├──apigee/apigee-client-php 2.0.5 (requires php-http/httplug ^1.1)
│ ├──apigee/devportal-kickstart-project (requires apigee/apigee-client-php dev-issue/41 as 2.0.6)
│ ├──drupal/apigee_edge 1.18.0 (requires apigee/apigee-client-php ^2.0.4)
│ │ ├──apigee/apigee_devportal_kickstart 1.21.0 (requires drupal/apigee_edge ^1.16)
│ │ │ └──apigee/devportal-kickstart-project (requires apigee/apigee_devportal_kickstart ^1.0.0)
│ │ └──drupal/apigee_m10n 1.7.0 (requires drupal/apigee_edge ^1.16)
│ │ └──apigee/devportal-kickstart-project (requires drupal/apigee_m10n ^1.0.0)
│ └──drupal/apigee_m10n 1.7.0 (requires apigee/apigee-client-php ~2.0.3)
│ └──apigee/devportal-kickstart-project (requires drupal/apigee_m10n ^1.0.0)
├──php-http/client-common 1.10.0 (requires php-http/httplug ^1.1)
│ └──apigee/apigee-client-php 2.0.5 (requires php-http/client-common ^1.9)
│ ├──apigee/devportal-kickstart-project (requires apigee/apigee-client-php dev-issue/41 as 2.0.6)
│ ├──drupal/apigee_edge 1.18.0 (requires apigee/apigee-client-php ^2.0.4)
│ │ ├──apigee/apigee_devportal_kickstart 1.21.0 (requires drupal/apigee_edge ^1.16)
│ │ │ └──apigee/devportal-kickstart-project (requires apigee/apigee_devportal_kickstart ^1.0.0)
│ │ └──drupal/apigee_m10n 1.7.0 (requires drupal/apigee_edge ^1.16)
│ │ └──apigee/devportal-kickstart-project (requires drupal/apigee_m10n ^1.0.0)
│ └──drupal/apigee_m10n 1.7.0 (requires apigee/apigee-client-php ~2.0.3)
│ └──apigee/devportal-kickstart-project (requires drupal/apigee_m10n ^1.0.0)
└──php-http/guzzle6-adapter v1.1.1 (requires php-http/httplug ^1.0)
└──drupal/apigee_edge 1.18.0 (requires php-http/guzzle6-adapter ^1.1.1)
├──apigee/apigee_devportal_kickstart 1.21.0 (requires drupal/apigee_edge ^1.16)
│ └──apigee/devportal-kickstart-project (requires apigee/apigee_devportal_kickstart ^1.0.0)
└──drupal/apigee_m10n 1.7.0 (requires drupal/apigee_edge ^1.16)
└──apigee/devportal-kickstart-project (requires drupal/apigee_m10n ^1.0.0)
So it seems that to drop support for HTTPlug 1.x we would also need to require the 2.x from the apigee_edge module. Does this sound right to you?
|
@arlina-espinoza yes it does, just |
arlina-espinoza
approved these changes
Nov 29, 2020
There was a problem hiding this comment.
LGTM, created apigee/apigee-edge-drupal#525 to support it from the drupal/apigee_edge side.
arlina-espinoza
added a commit
to apigee/apigee-mock-client-php
that referenced
this pull request
Dec 7, 2020
Updated dependencies to support: - apigee/apigee-edge-drupal#525 - apigee/apigee-client-php#106
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41