Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ClientInterface constant names and HybridOauth2 class to fit new Apigee naming #112

Closed
cnovak opened this issue Dec 3, 2020 · 0 comments · Fixed by #164
Closed

Change ClientInterface constant names and HybridOauth2 class to fit new Apigee naming #112

cnovak opened this issue Dec 3, 2020 · 0 comments · Fixed by #164
Assignees
@phdhiren
Labels
enhancement New feature or request

Comments

@cnovak
Copy link
Collaborator

cnovak commented Dec 3, 2020

The Apigee product used to be hosted at apigee.com. The newer platform of Apigee is now at apigee.google.com and uses Google Cloud. The actual names of these platforms have been changed to:

  • apigee.com: Apigee Edge
  • apigee.google.com: Apigee on Google Cloud

Hybrid is the name for a specific flavor of Apigee on Google Cloud where the Apigee runtime is hosted in a different location than Google Cloud. However, the Apigee API and admin features are still at apigee.google.com.

Since we did not understand the naming when we created the feature, the constant ClientInterface::HYBRID_ENDPOINT is not correct. In the ClientInteface, the constants should be renamed:

  • ClientInterface::DEFAULT_ENDPOINT should be EDGE_ENDPOINT
  • ClientInterface::HYBRID_ENDPOINT should be APIGEE_ON_GCP_ENDPOINT

To avoid breaking changes, the original constants should be marked as deprecated, and the new constants added until we can remove them in a 3.x version. Add comments to explain this info above.

The class HybridOauth2 class is also named incorrectly, and should be deprecated in favor of a class named ApigeeOnGcpOauth2
@cnovak cnovak added the enhancement New feature or request label Dec 3, 2020
@cnovak cnovak self-assigned this Dec 3, 2020
@cnovak cnovak mentioned this issue Dec 3, 2020
Closed
@cnovak cnovak modified the milestones: 3.x, 2.0.7 Jan 12, 2021
@raakesh-blokhra raakesh-blokhra modified the milestones: 2.0.7, 3.x Apr 19, 2021
@phdhiren phdhiren mentioned this issue Jul 7, 2021
Closed
phdhiren added a commit to phdhiren/apigee-client-php that referenced this issue Jul 7, 2021
@phdhiren
[apigee#112] Change ClientInterface constant names and HybridOauth2 c…
71e3f57 
…lass to fit new Apigee naming
phdhiren added a commit to phdhiren/apigee-client-php that referenced this issue Jul 7, 2021
@phdhiren
[apigee#112] Change ClientInterface constant names and HybridOauth2 c…
321df25 
…lass to fit new Apigee naming
@phdhiren phdhiren modified the milestones: 3.x, 2.0.9 Jul 7, 2021
@phdhiren phdhiren mentioned this issue Jul 7, 2021
Closed
@phdhiren phdhiren assigned phdhiren and unassigned cnovak Jul 7, 2021
@phdhiren phdhiren linked a pull request Jul 7, 2021 that will close this issue
[#112] Change ClientInterface constant names and HybridOauth2 class to fit new Apigee naming #164
Merged
raakesh-blokhra pushed a commit that referenced this issue Jul 19, 2021
@phdhiren
[#112] Change ClientInterface constant names and HybridOauth2 class t…
658c2e5 
…o fit new Apigee naming (#164)

* [#112] Change ClientInterface constant names and HybridOauth2 class to fit new Apigee naming

* [#112] Change ClientInterface constant names and HybridOauth2 class to fit new Apigee naming

* Fixes phpdoc_separation error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phdhiren phdhiren

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@cnovak @raakesh-blokhra @phdhiren