Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes PHPCS issues #262

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Fixes PHPCS issues #262

merged 1 commit into from
Oct 1, 2024

Conversation

kedarkhaire
Copy link
Collaborator

PHPCS fix includes the following fixes

  1. Use statement sort in alphabetically order
  2. Parameter has null default value, but is not marked as nullable.

@kedarkhaire kedarkhaire added this to the 3.0.8 milestone Sep 25, 2024
@kedarkhaire
Copy link
Collaborator Author

Commands used to analyze and fix the PHPCS issues

  1. Fix code style issues & apply automatic code style fixes with PHPCBF.
    vendor/bin/phpcbf --standard=web/modules/contrib/apigee_api_catalog/phpcs.xml.dist web/modules/contrib/apigee_api_catalog -s --colors

  2. Check remaining code style issues with PHPCS and fix them manually.
    vendor/bin/phpcs --standard=web/modules/contrib/apigee_api_catalog/phpcs.xml.dist web/modules/contrib/apigee_api_catalog -p -s -n --colors

Thanks!

shishir-intelli
shishir-intelli approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@shishir-intelli shishir-intelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shishir-intelli shishir-intelli merged commit 1a2b851 into apigee:3.x Oct 1, 2024
1 of 7 checks passed
@kedarkhaire kedarkhaire self-assigned this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shishir-intelli shishir-intelli shishir-intelli approved these changes

@giteshk giteshk Awaiting requested review from giteshk

@divya-intelli divya-intelli Awaiting requested review from divya-intelli

Assignees

@kedarkhaire kedarkhaire

Labels
None yet
Projects
None yet
Milestone
3.0.8
Development

Successfully merging this pull request may close these issues.
2 participants
@kedarkhaire @shishir-intelli