Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the yml extension from field_apidoc_file_link and field_apidoc_spec allowed values - 3.x branch #176

Merged
merged 4 commits into from
Mar 30, 2022

Conversation

shishir-intelli
Copy link
Collaborator

@shishir-intelli shishir-intelli commented Mar 29, 2022

Closes #152

This PR is for 3.x branch

Remove .yml extension from field_apidoc_file_link and field_apidoc_spec allowed values because in Drupal 8+ .yml can contain sensitive information which can cause security issues.

@shishir-intelli shishir-intelli added this to the 3.0.1 milestone Mar 29, 2022
@shishir-intelli shishir-intelli changed the title Remove the yml extension from field_apidoc_file_link and field_apidoc_spec allowed values - v3.x Remove the yml extension from field_apidoc_file_link and field_apidoc_spec allowed values - 3.x branch Mar 29, 2022
Copy link
Collaborator

@phdhiren phdhiren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shishir-intelli
Copy link
Collaborator Author

For deprecated methods we will create separate issues.

@shishir-intelli shishir-intelli merged commit bd8f445 into apigee:3.x Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API Catalog does not render API documentation when using YML specs.
2 participants