Switch to TypeScript #31
Conversation
|
|
||
| /** | ||
| * @param {object} options | ||
| */ | ||
| function optionsValidationHandler(options) { | ||
| export function optionsValidationHandler(options: unknown): void { |
There was a problem hiding this comment.
The possible options are quite well known, no?
There was a problem hiding this comment.
They aren't known upon validation. We could type asserts options it T but it still doesn't matter as this is a hook.
|
cc @vladfrangu |
szmarczak
force-pushed
the
ts
branch
2 times, most recently
from
5cd9921
to
2ac65a6
Compare
src/hooks/http2.ts
Outdated
|
|
||
| export function http2Hook(options: Options) { | ||
| if (options.http2 && (options.url as URL).protocol !== 'http:') { | ||
| // @ts-expect-error FIXME |
There was a problem hiding this comment.
this are still a lot of those FIXME type comments, do you plan to resolve all of them before merging the PR? if not, we should be probably more specific instead of just saying FIXME, at least in the actual code base (it's fine'ish in tests)
Fixed the two in The ones in The PR is good to merge if there is no more questions. |
|
@B4nan Friendly ping :) |
TODO after this gets merged:
Closes #21