feat: resilient sitemap loading #2619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barjin
added
the
feature
github-actions
bot
added
t-tooling
janbuchar
reviewed
Aug 14, 2024
janbuchar
reviewed
Aug 14, 2024
| method: 'GET', | ||
| timeout: networkTimeouts, | ||
| headers: { | ||
| 'accept': 'application/xhtml+xml,application/xml,text/plain', |
There was a problem hiding this comment.
Can't this make a well-behaved server not return a .gz file? I'd say Content negotiation failed in this case.
There was a problem hiding this comment.
This is (a shortened) version of what regular web browsers send in the accept header. I added a */* directive to allow for any type the server has. The accept-encoding header is something got-scraping sets itself, as it depends on the HTTP client capabilities.
I say let's monitor for errors like this, worst case, we know where to look :)
There was a problem hiding this comment.
Do browsers send that for files that end in .gz as well? It sounds fishy...
janbuchar
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds:
async SitemapRequestList.teardown()Allows users to signal that they won't need the
SitemapRequestListinstance anymore (so the sitemap loading can stop and trash all pending URLs). Internally, this unblocks the waitingpushNextUrlcalls and allows the runtime environment to terminate correctly.On-error retries for
parseSitemap()Network errors do not crash the
parseSitemap()orSitemapRequestList.load()calls anymore. Instead, the sitemap load is retried (plus, withSitemapRequestList, the URLs aren't duplicated if the error happened somewhere in the middle of the sitemap load).Parametrizable network timeouts for
parseSitemap()Both
parseSitemap()andSitemapRequestList.load()calls now accept got-like timeout object (see more details here). This can help with issues described in #2577 .Closes #2577
Closes #2617