-
Notifications
You must be signed in to change notification settings - Fork 56
Conversation
@@ -138,7 +138,7 @@ TEST_CASE("Identifier enclosed by backticks", "[signature]") | |||
REQUIRE(blueprint.report.error.code == Error::OK); | |||
REQUIRE(blueprint.report.warnings.empty()); | |||
|
|||
REQUIRE(signature.identifier == "username `is` g``ood"); | |||
REQUIRE(signature.identifier == "```username `is` g``ood```"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you confirm that the property name is this case will be
username `is` g``ood
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me check one more time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is before the PR for sure, not sure how it changed after this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FORMAT: 1A
# API
## A [GET /]
+ Response 200 (application/json)
+ Attributes (object)
+ ```username `is` g``ood```: username
result
{
"element": "parseResult",
"content": [
{
"element": "category",
"meta": {
"classes": [
"api"
],
"title": "API"
},
"attributes": {
"meta": [
{
"element": "member",
"meta": {
"classes": [
"user"
]
},
"content": {
"key": {
"element": "string",
"content": "FORMAT"
},
"value": {
"element": "string",
"content": "1A"
}
}
}
]
},
"content": [
{
"element": "category",
"meta": {
"classes": [
"resourceGroup"
],
"title": ""
},
"content": [
{
"element": "resource",
"meta": {
"title": "A"
},
"attributes": {
"href": "/"
},
"content": [
{
"element": "transition",
"meta": {
"title": "A"
},
"attributes": {
"href": "/"
},
"content": [
{
"element": "httpTransaction",
"content": [
{
"element": "httpRequest",
"attributes": {
"method": "GET"
},
"content": []
},
{
"element": "httpResponse",
"attributes": {
"statusCode": "200",
"headers": {
"element": "httpHeaders",
"content": [
{
"element": "member",
"content": {
"key": {
"element": "string",
"content": "Content-Type"
},
"value": {
"element": "string",
"content": "application/json"
}
}
}
]
}
},
"content": [
{
"element": "dataStructure",
"content": [
{
"element": "object",
"content": [
{
"element": "member",
"content": {
"key": {
"element": "string",
"content": "username `is` g``ood"
},
"value": {
"element": "string",
"content": "username"
}
}
}
]
}
]
},
{
"element": "asset",
"meta": {
"classes": [
"messageBody"
]
},
"attributes": {
"contentType": "application/json"
},
"content": "{\n \"username `is` g``ood\": \"username\"\n}"
},
{
"element": "asset",
"meta": {
"classes": [
"messageBodySchema"
]
},
"attributes": {
"contentType": "application/schema+json"
},
"content": "{\n \"$schema\": \"http://json-schema.org/draft-04/schema#\",\n \"type\": \"object\",\n \"properties\": {\n \"username `is` g``ood\": {\n \"type\": \"string\"\n }\n }\n}"
}
]
}
]
}
]
}
]
}
]
}
]
}
]
}
Seems OK
Only a single question. Otherwise, lgtm. |
0d6a171
to
816a12b
Compare
Merge away when tests pass. |
Appveyor status update seems not to be working ... see https://ci.appveyor.com/project/Apiary/snowcrash/history |
No description provided.