Skip to content
This repository has been archived by the owner on Oct 1, 2018. It is now read-only.

fix: escaped property name #422

Merged
merged 1 commit into from
Dec 5, 2016
Merged

fix: escaped property name #422

merged 1 commit into from
Dec 5, 2016

Conversation

w-vi
Copy link
Contributor

@w-vi w-vi commented Dec 5, 2016

No description provided.

@@ -138,7 +138,7 @@ TEST_CASE("Identifier enclosed by backticks", "[signature]")
REQUIRE(blueprint.report.error.code == Error::OK);
REQUIRE(blueprint.report.warnings.empty());

REQUIRE(signature.identifier == "username `is` g``ood");
REQUIRE(signature.identifier == "```username `is` g``ood```");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm that the property name is this case will be

username `is` g``ood

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me check one more time

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is before the PR for sure, not sure how it changed after this PR.

Copy link
Contributor Author

@w-vi w-vi Dec 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FORMAT: 1A

# API

## A [GET /]

+ Response 200 (application/json)

    + Attributes (object)
        + ```username `is` g``ood```: username

result

{
  "element": "parseResult",
  "content": [
    {
      "element": "category",
      "meta": {
        "classes": [
          "api"
        ],
        "title": "API"
      },
      "attributes": {
        "meta": [
          {
            "element": "member",
            "meta": {
              "classes": [
                "user"
              ]
            },
            "content": {
              "key": {
                "element": "string",
                "content": "FORMAT"
              },
              "value": {
                "element": "string",
                "content": "1A"
              }
            }
          }
        ]
      },
      "content": [
        {
          "element": "category",
          "meta": {
            "classes": [
              "resourceGroup"
            ],
            "title": ""
          },
          "content": [
            {
              "element": "resource",
              "meta": {
                "title": "A"
              },
              "attributes": {
                "href": "/"
              },
              "content": [
                {
                  "element": "transition",
                  "meta": {
                    "title": "A"
                  },
                  "attributes": {
                    "href": "/"
                  },
                  "content": [
                    {
                      "element": "httpTransaction",
                      "content": [
                        {
                          "element": "httpRequest",
                          "attributes": {
                            "method": "GET"
                          },
                          "content": []
                        },
                        {
                          "element": "httpResponse",
                          "attributes": {
                            "statusCode": "200",
                            "headers": {
                              "element": "httpHeaders",
                              "content": [
                                {
                                  "element": "member",
                                  "content": {
                                    "key": {
                                      "element": "string",
                                      "content": "Content-Type"
                                    },
                                    "value": {
                                      "element": "string",
                                      "content": "application/json"
                                    }
                                  }
                                }
                              ]
                            }
                          },
                          "content": [
                            {
                              "element": "dataStructure",
                              "content": [
                                {
                                  "element": "object",
                                  "content": [
                                    {
                                      "element": "member",
                                      "content": {
                                        "key": {
                                          "element": "string",
                                          "content": "username `is` g``ood"
                                        },
                                        "value": {
                                          "element": "string",
                                          "content": "username"
                                        }
                                      }
                                    }
                                  ]
                                }
                              ]
                            },
                            {
                              "element": "asset",
                              "meta": {
                                "classes": [
                                  "messageBody"
                                ]
                              },
                              "attributes": {
                                "contentType": "application/json"
                              },
                              "content": "{\n  \"username `is` g``ood\": \"username\"\n}"
                            },
                            {
                              "element": "asset",
                              "meta": {
                                "classes": [
                                  "messageBodySchema"
                                ]
                              },
                              "attributes": {
                                "contentType": "application/schema+json"
                              },
                              "content": "{\n  \"$schema\": \"http://json-schema.org/draft-04/schema#\",\n  \"type\": \"object\",\n  \"properties\": {\n    \"username `is` g``ood\": {\n      \"type\": \"string\"\n    }\n  }\n}"
                            }
                          ]
                        }
                      ]
                    }
                  ]
                }
              ]
            }
          ]
        }
      ]
    }
  ]
}

Seems OK

@pksunkara
Copy link
Contributor

Only a single question. Otherwise, lgtm.

@w-vi w-vi force-pushed the wvi/eascaped-name branch from 0d6a171 to 816a12b Compare December 5, 2016 15:30
@pksunkara
Copy link
Contributor

Merge away when tests pass.

@w-vi
Copy link
Contributor Author

w-vi commented Dec 5, 2016

Appveyor status update seems not to be working ... see https://ci.appveyor.com/project/Apiary/snowcrash/history

@pksunkara pksunkara merged commit 2d52dda into master Dec 5, 2016
@pksunkara pksunkara deleted the wvi/eascaped-name branch December 5, 2016 16:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants