This repository has been archived by the owner on Oct 1, 2018. It is now read-only.
Fix #345 #403
Merged
Fix #345 #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -403,6 +403,32 @@ namespace snowcrash { | |||
| } | |||
| } | |||
|
|
|||
| static size_t matchBracket(const mdp::ByteBuffer& text) { | |||
There was a problem hiding this comment.
There should already be a function like this somewhere in snowcrash. We can use that.
There was a problem hiding this comment.
I think this function? Not sure if it does the same thing though.
https://github.com/apiaryio/snowcrash/blob/master/src/SignatureSectionProcessor.h#L363
There was a problem hiding this comment.
Yup, that one. It has more logic for matching brackets, and we can use the output here to get the last bracket pos. So, it should be okay to use it.
klokane
force-pushed
the
klokane/fix-345
branch
from
1638ae9 to
55635e0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSON aligned parameter parser trips up when inline description contains round brackets