This repository has been archived by the owner on Oct 1, 2018. It is now read-only.
Add typed attribute #398
Merged
Add typed attribute #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -181,6 +181,9 @@ namespace mson { | |||
| else if (attribute == "nullable") { | |||
| typeAttributes |= NullableTypeAttribute; | |||
| } | |||
| else if (attribute == "typed") { | |||
There was a problem hiding this comment.
Please name it fixed-type.
| @@ -135,7 +135,8 @@ namespace mson { | |||
| FixedTypeAttribute = (1 << 2), // The type is fixed | |||
| SampleTypeAttribute = (1 << 3), // The type is a sample | |||
| DefaultTypeAttribute = (1 << 4), // The type is default | |||
| NullableTypeAttribute = (1 << 5) // The type is nullable | |||
| NullableTypeAttribute = (1 << 5), // The type is nullable | |||
| TypedTypeAttribute = (1 << 6) // This type works like fixed, but it is unheritable | |||
There was a problem hiding this comment.
We can do FixedTypeTypeAttribute.
|
Only 1 comment, otherwise lgtm. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion in apiaryio/mson#66