Skip to content
This repository has been archived by the owner on Nov 8, 2024. It is now read-only.

Use weak comparison for statusCode validation #159

Closed
artem-zakharchenko opened this issue May 14, 2019 · 1 comment · Fixed by #172
Closed

Use weak comparison for statusCode validation #159

artem-zakharchenko opened this issue May 14, 2019 · 1 comment · Fixed by #172

Comments

@artem-zakharchenko
Copy link
Contributor

I suggest to replace the usage of TextDiff for statusCode validation to weak comparison (==).

Motivation

TextDiff brings some additional information irrelevant for statusCode (line/columns). Numbers comparison should be enough to provide meaningful validation results for status codes.

@artem-zakharchenko artem-zakharchenko self-assigned this May 21, 2019
artem-zakharchenko added a commit that referenced this issue May 22, 2019
Closes #159

BREAKING CHANGE: Gavel doesn't return text diff data on status code comparison anymore.
artem-zakharchenko added a commit that referenced this issue May 24, 2019
Closes #159

BREAKING CHANGE: Gavel doesn't return text diff data on status code comparison anymore.
@ApiaryBot
Copy link
Collaborator

🎉 This issue has been resolved in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants