This repository has been archived by the owner on Nov 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 280
Language agnostic hooks bridge & transaction compiler extraction #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uby puts is working
netmilk
force-pushed
the
netmilk/ruby-polishing
branch
from
June 30, 2015 14:49
985746c
to
783cf6c
Compare
netmilk
changed the title
Integration tests for every type of hooks in Ruby worker
Language agnostic hooks bridge & transaction compiler extraction
Jul 6, 2015
- [Ruby](hooks-ruby.md) | ||
- [Python](hooks-python.md) | ||
- [Node.js](hooks-node.md) | ||
- *Addd your language here* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: Addd
vs. Add
|
||
- [Ruby](hooks-ruby.md) | ||
- [Python](hooks-python.md) | ||
- [Node.js](hooks-node.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all links should point to docs
folder
@@ -13,6 +14,8 @@ mergeSandboxedHooks = require './merge-sandboxed-hooks' | |||
addHooks = (runner, transactions, callback) -> | |||
# Note: runner.configuration.options must be defined | |||
|
|||
customConfigCwd = runner?.configuration?.custom?.cwd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment above said at least runner.configuration
is always accessible, so no need to runner?.configuration?
Large ToDo
Maybe:
|
netmilk
pushed a commit
that referenced
this pull request
Jul 7, 2015
Language agnostic hooks bridge & transaction compiler extraction
artem-zakharchenko
pushed a commit
that referenced
this pull request
Oct 9, 2019
Update mocha to the latest version 🚀
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dredd-hooks-ruby
packagedredd-hooks-pyhon
packageblueprint-transactions
(First step for Canonical transaction paths #227 and Inconsistent behaviour of --names option #210, closes Extract HTTP transaction compiling and canonical name matching to dedicated package #226)