Skip to content
This repository has been archived by the owner on Nov 8, 2024. It is now read-only.

Language agnostic hooks bridge & transaction compiler extraction #230

Merged
merged 28 commits into from
Jul 7, 2015

Conversation

netmilk
Copy link
Contributor

@netmilk netmilk commented Jun 24, 2015

@netmilk netmilk force-pushed the netmilk/ruby-polishing branch from 985746c to 783cf6c Compare June 30, 2015 14:49
@netmilk netmilk changed the title Integration tests for every type of hooks in Ruby worker Language agnostic hooks bridge & transaction compiler extraction Jul 6, 2015
- [Ruby](hooks-ruby.md)
- [Python](hooks-python.md)
- [Node.js](hooks-node.md)
- *Addd your language here*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: Addd vs. Add


- [Ruby](hooks-ruby.md)
- [Python](hooks-python.md)
- [Node.js](hooks-node.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all links should point to docs folder

@@ -13,6 +14,8 @@ mergeSandboxedHooks = require './merge-sandboxed-hooks'
addHooks = (runner, transactions, callback) ->
# Note: runner.configuration.options must be defined

customConfigCwd = runner?.configuration?.custom?.cwd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment above said at least runner.configuration is always accessible, so no need to runner?.configuration?

@kuba-kubula
Copy link
Member

Large ToDo

  • refactor hooks running from "sync" into "async" callers (without proxyquire)
  • process.exit (used at Hooks) should be some runner callback to bubble up through all the flow back to dredd.run callback
  • DRY hooks-worker (factory for ...All and ...Each)
  • Get rid with hard sleeps with while true with refactoring to async callbacks

Maybe:

  • introduce "prepared" message from worker/process/ruby/python back to Dredd that the hook-machine is prepared so Dredd can actually start connecting to the server (or introduce a Dredd.connectToHookMachine with a retry mechanism)

netmilk pushed a commit that referenced this pull request Jul 7, 2015
Language agnostic hooks bridge & transaction compiler extraction
@netmilk netmilk merged commit 267c7d9 into master Jul 7, 2015
@kuba-kubula
Copy link
Member

Please see @netmilk @w-vi see the Large ToDo comment above - we just got caught by it in issues with hooks-worker-client

artem-zakharchenko pushed a commit that referenced this pull request Oct 9, 2019
Update mocha to the latest version 🚀
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants