fix: wait for process to be killed before tmp dir gets wiped

apiaryio · Jun 5, 2019 · 86bce41 · 86bce41
1 parent 8dbb73b
commit 86bce41
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 9 deletions.
diff --git a/features/support/steps.js b/features/support/steps.js
@@ -7,7 +7,7 @@ const fs = require('fs-extra');
 const net = require('net');
 const url = require('url');
 const which = require('which');
-const kill = require('tree-kill');
+const pidtree = require('pidtree');
 const {
   Given,
   When,
@@ -25,8 +25,14 @@ Before(function hook() {
 });
 
 After(async function hook() {
-  fs.remove(this.dir);
-  await util.promisify(kill)(this.proc.pid);
+  const pids = [];
+  try {
+    pids.push(...await pidtree(this.proc.pid));
+  } catch (error) {
+    // the process doesn't exist anymore
+  }
+  pids.forEach(pid => process.kill(pid, 'SIGKILL'));
+  return fs.remove(this.dir);
 });
 
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -14,7 +14,7 @@
     "dredd": "11.2.6",
     "fs-extra": "8.0.1",
     "glob": "7.1.4",
-    "tree-kill": "1.2.1",
+    "pidtree": "0.3.0",
     "which": "1.3.1"
   },
   "devDependencies": {