This repository has been archived by the owner on Nov 8, 2024. It is now read-only.
fix: Infinite loop issue #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snowcrash should give out a circular reference error when an attirbutes section is reference itself even when a description header node is present before it.
kylef
reviewed
Oct 18, 2017
| @@ -181,7 +181,8 @@ namespace snowcrash | |||
|
|
|||
| contextSectionType = sectionType; | |||
| contextCur = cur; | |||
| } else if (contextSectionType != DataStructureGroupSectionType) { | |||
| } else if (contextSectionType != DataStructureGroupSectionType | |||
| && SectionProcessor<Action>::sectionType(cur) == ActionSectionType) { | |||
There was a problem hiding this comment.
I'm wondering what the difference would be between SectionProcessor<Action>::sectionType(cur) == ActionSectionType and sectionType == ActionSectionType. Could you please explain?
There was a problem hiding this comment.
sectionType will be UndefinedSectionType because in BlueprintParser's nestedSectionType(), we don't check for ActionType since it is not a direct child of Blueprint.
There was a problem hiding this comment.
The test is still passing with this though: d92137c
There was a problem hiding this comment.
I remember other tests failing with that. It is the first thing I tried too.
kylef
approved these changes
Oct 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snowcrash should give out a circular reference error when an attirbutes
section is reference itself even when a description header node is present
before it.
This is actually a better fix for #328 than the one we did in #329