Fix NaN value incorrectly passing validation as a number.

[selaux]

Currently an object with a NaN parameter that is required to be a number in the schema will validate without an error. Since NaN is not actually a value that can appear in JSON and is called "Not a Number" is should not validate as a number.

var amanda = require('amanda');
var schema = {
  type: 'object',
  properties: {
    name: {
      required: true,
      type: 'number'
    }
  }
};
var data = {
  name: NaN
};

var jsonSchemaValidator = amanda('json');
jsonSchemaValidator.validate(data, schema, function(error) {
  console.log(error); // Currently outputs null, but should throw an error
});

[kuba-kubula]

Hi @selaux.
In regards to http://stackoverflow.com/a/26518924 and taken into account the fact that Amanda is meant for JSON validations, I'd never receive NaN as value anywhere, so it is ok.

[selaux]

Well imho it's still an invalid value passing as valid. Even the post you linked sais Therefore any schema for JSON structures which permitted NaN would be permitting things that are not JSON.. If Amanda should only validate JSON it should take a JSON string as an input, parse it internally and tell me if that string is valid, not take an object and tell me it's valid although it is clearly not.

[kuba-kubula]

would you please change the number here too, so the expect...eql is in sync with the test comment?

[selaux]

Done.