Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add _gasPrice reserved parameter #56

Merged
merged 1 commit into from
Dec 15, 2022
Merged

feat: add _gasPrice reserved parameter #56

merged 1 commit into from
Dec 15, 2022

Conversation

dcroote
Copy link
Contributor

@dcroote dcroote commented Dec 15, 2022

Closes #50. Builds off of the validation implemented in #52 given _gasPrice and _minConfirmations are both new reserved parameters with the same type.

Copy link
Contributor

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@dcroote dcroote merged commit 0101775 into main Dec 15, 2022
@dcroote dcroote deleted the dcroote/issue50 branch December 15, 2022 13:47
@dcroote dcroote mentioned this pull request Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add reserved parameter for specifying gas price
2 participants