-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Bump axios and api3 deps #1921
Conversation
Remove reliance on deployed RequesterAuthorizerWithErc721 addresses
1ac5abc
to
895f9cd
Compare
I would leave the RequesterAuthorizerWithErc721 stuff in, it's just that the old deployments are no longer valid and should not auto-populate the config. When we deploy the new versions, we want them to auto-populate the config. |
Agreed and I should have described the PR better- I've taken out only the code / tests that rely on the existence of a deployment (for which there are none currently) |
If it's going to make things easier later, I can do a Sepolia deployment. I don't expect the contract to change later. |
If possible I think that would be easiest as then none of the tests or configs would change beyond the new default Sepolia address. I know it isn't high priority to deploy the contract and then release though. |
I deployed RequesterAuthorizerWithErc721 on Sepolia and published @api3/[email protected] |
Change RequesterAuthorizerWithErc721 related chainIds to 11155111 to utilize the Sepolia deployment
Thank you! I reverted back to the original configs and tests, with minor updates to use the new Sepolia deployment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I had forgotten about this 🙏
* Update RequesterAuthorizerWithErc721 related tests to use new Sepolia deployment
Remove reliance on deployed RequesterAuthorizerWithErc721 addresses