fix: populate default contract addresses when loading config #1814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amarthadan
approved these changes
Jun 26, 2023
Comment on lines
+19
to
+22
| delete invalidConfig.chains[0].contracts; | ||
| delete invalidConfig.chains[0].authorizers.crossChainRequesterAuthorizers[0].contracts; | ||
| delete invalidConfig.chains[0].authorizers.crossChainRequesterAuthorizersWithErc721[0].contracts; | ||
| delete invalidConfig.chains[0].authorizers.requesterAuthorizersWithErc721[0].RequesterAuthorizerWithErc721; |
There was a problem hiding this comment.
Why did you populate those fields in the example config if you're then emptying them here?
There was a problem hiding this comment.
The authorizers that have been added to the config are objects with several fields- here I'm only deleting the optional contract field in each before then confirming via the test that the deployed address is added.
Co-authored-by: Michal Kimle <[email protected]>
|
I've tested this with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1809 by populating default contract address when a config file, which may omit contract addresses for which there is an existing deployment, is loaded via
loadTrustedConfig. Rather than duplicate the code to populate default addresses, this code calls validating functions added to airnode-validator as part of #1755.