Widen allowed HTTP parameters #1797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aquarat
force-pushed
the
1790-widen-http-params
branch
from
5cd83d3
to
d2035f9
Compare
aquarat
force-pushed
the
1790-widen-http-params
branch
from
d2035f9
to
874f9c4
Compare
|
@api3/ois has been published and references updated in this branch. |
dcroote
approved these changes
Jun 7, 2023
Ah yes I’ve come across that too @ multiple Zod versions. Thanks for sorting out/merging :) It might be worth asking the original issue reporting user to test the latest docker preview builds? |
dcroote
added a commit
that referenced
this pull request
Jun 8, 2023
* Widen parameter type * Fix validation tests * Update @api3/ois fixtures * Bump zod to match zod version in @api3/ois v2.1.0 --------- Co-authored-by: Derek Croote <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1790
Relates to this thread on Slack.
This PR widens the type of allowed fixedOperation parameters and HTTP call parameters that can be used in Airnode.
This PR goes hand-in-hand with api3dao/ois#88
This allows a user to configure Airnode, either via a fixedOperationParameter or via pre-processing, to send a set of complex or non-string parameters to the remote API. The user's use case was to embed an array containing a
falseelement in the JSON payload POSTed to an EVM node.The OIS package will be swapped for the real package once the OIS PR is approved and package published.
I have tested these changes via the HTTP gateways. The test configuration can be found in the Slack thread^
Example from config.json:
{ "operationParameter": { "in": "query", "name": "params" }, "value": [ "finalized", false ] }