Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to release scripts due to library updates #1774

Merged
merged 1 commit into from
May 22, 2023

Conversation

amarthadan
Copy link
Contributor

No description provided.

@amarthadan amarthadan requested a review from a team May 19, 2023 10:14
@amarthadan amarthadan self-assigned this May 19, 2023
Copy link
Contributor

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason for this change?

@amarthadan
Copy link
Contributor Author

I presume updates of yargs and promise-utils.

@@ -86,6 +86,7 @@ yargs(process.argv.slice(2))
handleCliCommand({
success: false,
error: new Error('Either provide the release Git branch or mount the Airnode source code directory'),
data: undefined,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Siegrift this (and the same below) is necessary because of your PR 😆 api3dao/promise-utils#90

Copy link
Contributor

@dcroote dcroote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amarthadan amarthadan merged commit 86ac79f into master May 22, 2023
@amarthadan amarthadan deleted the fix-release-scripts branch May 22, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants