Update RequesterAuthorizerWithErc721 #1771
Conversation
| settings: { | ||
| 'import/resolver': { | ||
| node: { | ||
| paths: ['src'], | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
I had to apply https://stackoverflow.com/a/42498220 even though I'm not confident what it really does
There was a problem hiding this comment.
Not entirely sure either, but I know I also fought with ESLint import errors previously in related work so glad there is something that appears to have worked.
There was a problem hiding this comment.
Nice- 1 response and 1 minor comment.
As for the other questions:
is it a problem for RequesterAuthorizerWithErc721 to only have been deployed on ethereum and ethereum-goerli-testnet
Not a problem per se - we'll default to these addresses if the contract address is omitted on these chains. Otherwise, users will have to (deploy and) specify it themselves.
Also, should #1755 also handle RequesterAuthorizerWithErc721?
Yes- this PR is perfectly timed as I can fix the TODOs in that PR once this is merged
packages/airnode-protocol/contracts/dev/RequesterAuthorizerWithErc721.sol
Outdated
Show resolved
Hide resolved
| settings: { | ||
| 'import/resolver': { | ||
| node: { | ||
| paths: ['src'], | ||
| }, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Not entirely sure either, but I know I also fought with ESLint import errors previously in related work so glad there is something that appears to have worked.
Closes #1675
@api3/[email protected] exports the audited RequesterAuthorizerWithErc721 and its addresses. This PR uses these instead of the contracts from
dev/.One question to @dcroote , is it a problem for RequesterAuthorizerWithErc721 to only have been deployed on ethereum and ethereum-goerli-testnet regarding #1717 ?
Also, should #1755 also handle RequesterAuthorizerWithErc721?