Remove MAXIMUM_SPONSOR_WALLET_REQUESTS to avoid throttling request fulfillments #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcroote
requested changes
May 10, 2023
There was a problem hiding this comment.
See my comment for clarification around the goal of the PR. Looking at the issue title I can see how this may have been unclear. Two other quick points:
- When your PR is ready to review, please mark it as such by clicking "Ready for review"
- See "2" within my comment here for the correct language to link a PR to an issue that the PR is closing.
|
I kept the |
dcroote
requested changes
May 12, 2023
dcroote
requested changes
May 15, 2023
dcroote
requested changes
May 17, 2023
|
Closes #1644 |
dcroote
approved these changes
May 18, 2023
packages/airnode-node/src/evm/handlers/fetch-pending-requests.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1644 by removing the
MAXIMUM_SPONSOR_WALLET_REQUESTSconstant. The initial intention of this constant was to prevent a single user from monopolizing the Airnode response bandwidth. However, as discussed in this thread, this measure is not effective, and it may obstruct legitimate usage.