Bump hardhat from 2.10.2 to 2.14.0 #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siegrift
reviewed
Apr 19, 2023
| @@ -34,7 +34,7 @@ | |||
| "@types/mocha": "^10.0.1", | |||
| "chai": "^4.3.7", | |||
| "ethereum-waffle": "^4.0.10", | |||
| "hardhat": "2.10.2", | |||
| "hardhat": "2.14.0", | |||
There was a problem hiding this comment.
Why is this a fixed version? (Renovate does not update it because of this). My guess is @bbenligiray was afraid about ABI changes?
There was a problem hiding this comment.
@Siegrift you actually pinned this in #1325 (comment) 😅
But in looking through the linked issues I believe it's resolved and we can both unpin and add back to renovate. WDYT?
There was a problem hiding this comment.
Yeah, I believe there was some issue with the combination of the plugins. I don't think this has any impact on the contracts so merging is fine (and also unpinning)
Siegrift
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1736 (I tested
yarn test:coveragewithinairnode-protocolruns).