Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include deployment_id in the heartbeat payload #1689

Merged
merged 2 commits into from
Mar 22, 2023
Merged

Include deployment_id in the heartbeat payload #1689

merged 2 commits into from
Mar 22, 2023

Conversation

dcroote
Copy link
Contributor

@dcroote dcroote commented Mar 22, 2023

Closes #1649.

@dcroote dcroote self-assigned this Mar 22, 2023
@dcroote dcroote requested a review from a team March 22, 2023 06:47
amarthadan
amarthadan approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@amarthadan amarthadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Don't forget to update the heartbeat documentation as well. There's a list of returned values.

@dcroote
Copy link
Contributor Author

dcroote commented Mar 22, 2023

Don't forget to update the heartbeat documentation as well.

Yes, api3dao/old-api3-docs#1224 is next on my list 👍

@dcroote dcroote merged commit 18fe3d0 into master Mar 22, 2023
@dcroote dcroote deleted the dcroote/issue1649 branch March 22, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amarthadan amarthadan amarthadan approved these changes

Assignees

@dcroote dcroote

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include the deployment_id in the heartbeat payload
2 participants
@dcroote @amarthadan