-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protocol contract deployment verification via CI #1627
Conversation
As seen here: https://github.com/api3dao/airnode/actions/runs/4041541899/jobs/6948239143 the CI is failing because of :
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -19,10 +19,10 @@ | |||
"deploy:deterministic": "DETERMINISTIC=true hardhat deploy --network $NETWORK --tags deploy && yarn run deploy:generate-references", | |||
"deploy:undeterministic": "hardhat deploy --network $NETWORK --tags deploy && yarn run deploy:generate-references", | |||
"deploy:verify": "hardhat deploy --network $NETWORK --tags verify", | |||
"deploy:verify-local": "hardhat run scripts/verify-local.ts --network $NETWORK", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense to move this under test:
, but the single network local verification came in handy while doing the deployments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cool I'll try to accommodate both
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use test:verify-local:network
for single network verification
Can you merge #1562 and merge master to 1594 so that we know that the CI also works for the new chains? |
Checks are passing, good to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the implementation in verify-local.ts
could be better compartmentalized to be more reusable. The current thing addresses the issue though so maybe someone will come back to this later.
Closes #1594
This add CI Verification to the protocol contracts using the
verify-local
script. I opted to return the list of all failed verifications and then throw the error instead of throwing an error at the first failed verification.airnode-protocol
folder changes then we need a separate workflow.airnode-protocol
folder has changed in theContinuous Build
workflow but its a third-party.airnode-protocol
folder has changed and run the CI on every workflow-run by incorporating it as an extra step of theContinuous Build
workflow