Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add handling of _minConfirmations reserved parameter #1615

Merged
merged 17 commits into from
Feb 2, 2023
Merged

Add handling of _minConfirmations reserved parameter #1615

merged 17 commits into from
Feb 2, 2023

Commits on Jan 20, 2023

  1. WIP: Add handling of _minConfirmations reserved parameter

    @dcroote
    dcroote committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    24b090c View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2023

  1. Add _minConfirmations to getReservedParameters test

    @dcroote
    dcroote committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    e08d8e0 View commit details
    Browse the repository at this point in the history

  2. Drop requests with _minConfirmations larger than BLOCK_COUNT_HISTORY_… 

    …LIMIT
    @dcroote
    dcroote committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    508c420 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. Filter requests based on block confirmations

    @dcroote
    dcroote committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    029eccf View commit details
    Browse the repository at this point in the history

  2. Add fetch comments

    @dcroote
    dcroote committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    927d14b View commit details
    Browse the repository at this point in the history

  3. Add e2e test

    @dcroote
    dcroote committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    54f6e48 View commit details
    Browse the repository at this point in the history

  4. Handle missing chains config and fix test

    @dcroote
    dcroote committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    302bf70 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2023

  1. Merge branch 'master' into dcroote/issue1393

    @dcroote
    dcroote committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    c08d605 View commit details
    Browse the repository at this point in the history

  2. Add transaction counts unit test

    @dcroote
    dcroote committed Jan 26, 2023
    Configuration menu
    Copy the full SHA
    5860999 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2023

  1. Move _minConfirmations request filtering upstream of API call

    @dcroote
    dcroote committed Jan 29, 2023
    Configuration menu
    Copy the full SHA
    32f1a8a View commit details
    Browse the repository at this point in the history

  2. Remove old tests

    @dcroote
    dcroote committed Jan 29, 2023
    Configuration menu
    Copy the full SHA
    84ef8c7 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2023

  1. Update logs

    @dcroote
    dcroote committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    451ebbe View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. Change implementation to apply max _minConfirmations by sponsor

    @dcroote
    dcroote committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    ef9a2a5 View commit details
    Browse the repository at this point in the history

  2. Fix filter and update test 

    compact will filter out minConfirmations of 0 so can't use
    @dcroote
    dcroote committed Jan 31, 2023
    Configuration menu
    Copy the full SHA
    2ac6345 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2023

  1. Simplify max value calculation, add logging, add tests

    @dcroote
    dcroote committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    bf17dd2 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. Address PR review comments

    @dcroote
    dcroote committed Feb 2, 2023
    Configuration menu
    Copy the full SHA
    bbe9343 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into dcroote/issue1393

    @dcroote
    dcroote authored Feb 2, 2023
    Configuration menu
    Copy the full SHA
    db72004 View commit details
    Browse the repository at this point in the history