Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change oracle gas strategy fallback log level to WARN #1549

Merged
merged 1 commit into from
Nov 27, 2022
Merged

Change oracle gas strategy fallback log level to WARN #1549

merged 1 commit into from
Nov 27, 2022

Conversation

dcroote
Copy link
Contributor

@dcroote dcroote commented Nov 24, 2022 •
edited
Loading

This PR changes ERROR to a more appropriate WARN for when one of a series of oracle gas strategies fails. Based on this Discord discussion.

Current behavior of a strategy that fails followed by a successful one (log level INFO):

[2022-11-24 06:11:02.820] ERROR Strategy (latestBlockPercentileGasPrice) failed to return a gas price. Error: Unable to get enough blocks or transactions to calculate percentileGasPrice.. Coordinator-ID:fc7f96081b
ffd482, Chain-ID:31337, Provider:exampleProvider, Endpoint-ID:0xfb87102cdabadf905321521ba0b3cbf74ad09c5d400ac2eccdbef8d6143e78c4, Sponsor-Address:0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266
[2022-11-24 06:11:02.820] INFO Strategy (providerRecommendedGasPrice) gas price set to 1.394093102 gwei.        Coordinator-ID:fc7f96081bffd482, Chain-ID:31337, Provider:exampleProvider, Endpoint-ID:0xfb87102cdaba
df905321521ba0b3cbf74ad09c5d400ac2eccdbef8d6143e78c4, Sponsor-Address:0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266

Creating PR as a draft to further investigate E2E test failures...

@dcroote dcroote force-pushed the oracle-log-level-warn branch from 85f993c to c51b0ff Compare November 25, 2022 19:37
@dcroote dcroote marked this pull request as ready for review November 25, 2022 19:38
@dcroote dcroote requested a review from a team November 25, 2022 20:10
@dcroote dcroote self-assigned this Nov 25, 2022
@dcroote dcroote added this to the 0.10.0 milestone Nov 26, 2022
Siegrift
Siegrift approved these changes Nov 27, 2022
View reviewed changes
Copy link
Contributor

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@dcroote dcroote merged commit 1005f80 into master Nov 27, 2022
@dcroote dcroote deleted the oracle-log-level-warn branch November 27, 2022 10:22
@dcroote dcroote mentioned this pull request Nov 27, 2022
Closed
@martinkolenic
Copy link
Contributor

martinkolenic commented Nov 29, 2022 •
edited
Loading

Hi, @dcroote, what testing strategy would you recommend for this issue? I am not quite sure I can induce a failure of gas price retrieval from the user's perspective.

@dcroote
Copy link
Contributor Author

dcroote commented Nov 30, 2022

@martinkolenic I tested this unintentionally in another issue and since it's a simple enough change (one word) I think we can move to done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siegrift Siegrift Siegrift approved these changes

Assignees

@dcroote dcroote

Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dcroote @martinkolenic @Siegrift