Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deployment ID generation #1548

Merged
merged 1 commit into from
Nov 28, 2022
Merged

Conversation

amarthadan
Copy link
Contributor

Fix #1546

Better error handling will be introduced in #1449

@amarthadan amarthadan requested a review from a team November 23, 2022 10:17
@amarthadan amarthadan self-assigned this Nov 23, 2022
Copy link
Contributor

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM, but didn't test.

@amarthadan amarthadan merged commit 6aaec34 into master Nov 28, 2022
@amarthadan amarthadan deleted the fix-deploymentid-interpolation branch November 28, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deployment ID is incorrectly generated for removal and info commands when GCP project ID value is interpolated
2 participants