-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.10 features so far #1497
v0.10 features so far #1497
Conversation
* Remove unnecessary validator bundling * Add changeset
@@ -54,7 +54,7 @@ | |||
}, | |||
"logFormat": "plain", | |||
"logLevel": "INFO", | |||
"nodeVersion": "0.9.0", | |||
"nodeVersion": "0.8.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this remains named as .valid.json it will get updated on next release and break again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It won't because the script is looking specifically for config.valid.json
and this is config.aws.valid.json
. I run the script and it was fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, okey.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last commit is newly added to fix broken deployer tests due to merge.
But when I check https://github.com/api3dao/airnode/tree/temp-v0.10.0 it says it's above master by 17 commits and this PR has also 17. What is the newly added commit you are talking about?
Is there something specific you want me to review? From the looks of it this is just backport of 0.10 so we can just merge it (so giving optimistic approve).
The last one, the |
Oh, I see. I forgot the 0.10 is not protected and you could merge directly. |
Just merging the temporary v0.10 branch back to
master
so we can continue development there.The last commit is newly added to fix broken deployer tests due to merge.