Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.10 features so far #1497

Merged
merged 17 commits into from
Oct 13, 2022
Merged

v0.10 features so far #1497

merged 17 commits into from
Oct 13, 2022

Conversation

amarthadan
Copy link
Contributor

@amarthadan amarthadan commented Oct 13, 2022

Just merging the temporary v0.10 branch back to master so we can continue development there.

The last commit is newly added to fix broken deployer tests due to merge.

@amarthadan amarthadan requested a review from a team October 13, 2022 07:19
@amarthadan amarthadan self-assigned this Oct 13, 2022
@@ -54,7 +54,7 @@
},
"logFormat": "plain",
"logLevel": "INFO",
"nodeVersion": "0.9.0",
"nodeVersion": "0.8.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this remains named as .valid.json it will get updated on next release and break again.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't because the script is looking specifically for config.valid.json and this is config.aws.valid.json. I run the script and it was fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, okey.

Copy link
Contributor

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The last commit is newly added to fix broken deployer tests due to merge.

But when I check https://github.com/api3dao/airnode/tree/temp-v0.10.0 it says it's above master by 17 commits and this PR has also 17. What is the newly added commit you are talking about?

Is there something specific you want me to review? From the looks of it this is just backport of 0.10 so we can just merge it (so giving optimistic approve).

@amarthadan
Copy link
Contributor Author

But when I check https://github.com/api3dao/airnode/tree/temp-v0.10.0 it says it's above master by 17 commits and this PR has also 17. What is the newly added commit you are talking about?

Is there something specific you want me to review? From the looks of it this is just backport of 0.10 so we can just merge it (so giving optimistic approve).

The last one, the Fix broken deployer tests one. That one was not there before, I added it to the branch without a PR to fix the tests.

@Siegrift
Copy link
Contributor

Oh, I see. I forgot the 0.10 is not protected and you could merge directly.

@amarthadan amarthadan merged commit c5b61a0 into master Oct 13, 2022
@amarthadan amarthadan deleted the temp-v0.10.0 branch October 13, 2022 14:16
@Siegrift Siegrift restored the temp-v0.10.0 branch November 3, 2022 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants