Enable cross-chain authorizers #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcroote
force-pushed
the
dcroote/issue1284
branch
from
0ba0edf
to
aa4c3dc
Compare
dcroote
force-pushed
the
dcroote/issue1284
branch
from
959d30c
to
f2ca933
Compare
Siegrift
requested changes
Oct 10, 2022
packages/airnode-examples/contracts/coingecko-e2e/EverythingAuthorizer.sol
Outdated
Show resolved
Hide resolved
packages/airnode-examples/test/example-files-are-up-to-date.test.ts
Outdated
Show resolved
Hide resolved
packages/airnode-node/src/evm/handlers/initialize-provider.test.ts
Outdated
Show resolved
Hide resolved
Having the addresses in secrets.env is unnecessarily roundabout for ending up with the addresses in config.json
Siegrift
approved these changes
Oct 18, 2022
| { | ||
| maxConcurrency: 100, | ||
| authorizers: { | ||
| requesterEndpointAuthorizers: ['0xE2E0000000000000000000000000000000000000'], |
There was a problem hiding this comment.
Nit: You can put them into secrets for easier implementation. But I know they are not secrets in practice so hardcoding makes sense as well.
There was a problem hiding this comment.
Thanks- I considered this, but because canonically we do not store addresses like this as secrets I opted instead for the placeholder addresses that get replaced.
Thanks. I make some fixes to the cross-chain aspects of the integration and confirmed it's now working on Sepolia (same chain) with a polygon mumbai cross-chain authorizer (in addition to localhost E2E via CI). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1284.
The core logic is in initialize-provider.ts and the coingecko-cross-chain-authorizer README has an explanation of how this user-runnable integration works.