Add cloud provider prefix to deployment ID #1480
Conversation
| @@ -511,6 +512,79 @@ export type Deployment = { | |||
| versions?: DeploymentVersion[]; | |||
| }; | |||
|
|
|||
| // If deploymentId is provided tries fetch only that one deployment and finishes early when found | |||
There was a problem hiding this comment.
If deploymentId is provided it tries to fetch only that one deployment and returns early when found
| @@ -511,6 +512,79 @@ export type Deployment = { | |||
| versions?: DeploymentVersion[]; | |||
| }; | |||
|
|
|||
| // If deploymentId is provided tries fetch only that one deployment and finishes early when found | |||
| async function fetchDeployments(cloudProvider: CloudProvider['type'], deploymentId?: string) { | |||
There was a problem hiding this comment.
Nit: I think we will be using type CloudProvider['type'] so consider defining it as type CloudProviderType = CloudProvider['type']
There was a problem hiding this comment.
I'm currently replacing it with a full CloudProvider type at some places so I'll see whether it makes sense.
|
|
||
| const latestDeployment = Object.keys(stageDirectory.children).sort().reverse()[0]; | ||
| const bucketConfigPath = `${airnodeAddress}/${stage}/${latestDeployment}/config.json`; | ||
| const config = JSON.parse( |
There was a problem hiding this comment.
I'd wrap this in go since this can fail in many ways (users manually edit aws config, we change the region and nodeVersion field). It would be nice to handle this gracefully.
There was a problem hiding this comment.
I'll do that as part of #1449
| const { id, cloudProvider, region, airnodeAddress, stage, airnodeVersion, lastUpdate, versions } = | ||
| deployment as Deployment; | ||
| const deployment = goCloudDeploymentInfo.data[0]; | ||
| const { id, region, airnodeAddress, stage, airnodeVersion, lastUpdate, versions } = deployment as Deployment; |
There was a problem hiding this comment.
Why is this not typed automatically? The go utils should provide inference for these things.
amarthadan
force-pushed
the
deployment-info
branch
from
2a78011 to
f32cdcd
Compare
amarthadan
force-pushed
the
deployment-id-cloud
branch
from
67fb485 to
a10b1ac
Compare
Close #1473