Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.6]: Fix GCP signed data gateway receipt URL, let deployer fail with non zero status code #1041

Merged
merged 5 commits into from
Apr 28, 2022

Conversation

Siegrift
Copy link
Contributor

Applies #1022 to the 0.6 release.

@Siegrift Siegrift requested a review from a team April 27, 2022 09:15
@Siegrift Siegrift self-assigned this Apr 27, 2022
@Siegrift Siegrift changed the base branch from master to v0.6 April 27, 2022 09:18
@Siegrift
Copy link
Contributor Author

I've tested this successfully. Instructions for @kolenic-martin :

  1. Check out this branch, use yarn build in the project root (needed to properly genearate config.json)
  2. Go to examples, choose signed data example + GCP (network does not matter)
  3. Run yarn create-airnode-config and yarn create-airnode-secrets
  4. Download the GCP service account key: https://docs.api3.org/airnode/v0.6/grp-providers/docker/deployer-image.html#gcp
  5. Edit the deploy-airnode and remove-airnode scripts to use the api3/airnode-deployer-dev:a39528e8282f3e65614748101d333168bc1ead28 image (built by the CI)
  6. Run deploy-airnode
  7. Make a successful signed data request
  8. Run remove-airnode

Also, please check whether the signed data documentation whether it's accurate: https://docs.api3.org/airnode/v0.6/grp-providers/guides/build-an-airnode/http-gateways.html#http-signed-data-gateway (it looks fine to me, but I only tested using airnode-examples).

Copy link
Contributor

@amarthadan amarthadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but leaving testing for @kolenic-martin

@Siegrift Siegrift merged commit 30b3b99 into v0.6 Apr 28, 2022
@Siegrift Siegrift deleted the v0.6-fix-deployer branch April 28, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants