Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename stage field in the configuration to deploymentId #1375

Closed
Tracked by #1605
amarthadan opened this issue Aug 10, 2022 · 1 comment
Closed
Tracked by #1605

Rename stage field in the configuration to deploymentId #1375

amarthadan opened this issue Aug 10, 2022 · 1 comment
Assignees
Milestone

Comments

@amarthadan
Copy link
Contributor

amarthadan commented Aug 10, 2022

We're using the stage field to distinguish between deployments anyway so we should make it official. The change is pretty much just the rename of the field but we should mention in the documentation that it is used to distinguish between the deployments and should be unique for each Airnode/deployment.

Slack discussion

@bbenligiray
Copy link
Member

This should be blocked by the cloud resource naming rework (because the assumption for this issue was that stage needs to be temporally unique, which may not be the case)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants