Skip to content
This repository has been archived by the owner on Aug 26, 2024. It is now read-only.

Rename stage field in the configuration to deploymentId #967

Closed
Tracked by #1605
amarthadan opened this issue Aug 11, 2022 · 6 comments
Closed
Tracked by #1605

Rename stage field in the configuration to deploymentId #967

amarthadan opened this issue Aug 11, 2022 · 6 comments
Assignees

Comments

@amarthadan
Copy link
Contributor

Documentation for api3dao/airnode#1375

@wkande
Copy link
Member

wkande commented Aug 11, 2022

@amarthadan - Who is doing this change. I see we are doing the documentation tasks differently now so I am not sure of the process.

@amarthadan
Copy link
Contributor Author

What do you mean? This will be done as part of api3dao/airnode#1375 by whoever will be working on that. This is the corresponding documentation task for that. We've been doing it this way since we switched to the GH board.

@wkande
Copy link
Member

wkande commented Aug 11, 2022

Usually the task was not split in the past. But this works better I think. I do not see anyone assigned so I do not know which developer is working on this and who I should contact to see if I can help. Are you just waiting to the next weekly Wednesday meeting to assign these? I see @aTeoke has also added a few.

@amarthadan
Copy link
Contributor Author

It was like this for the last, I don't know, two months? For example this Airnode issue and corresponding docs issue, or this Airnode issue and corresponding docs issue. We've discussed it here api3dao/airnode#1235.

But just to make it clear, the flow should be like this:
When there's an Airnode issue that needs documentation we assign the needs documentation label to it which triggers our automation and creates a corresponding issue in the docs repo. These two issues should be done by the same person unless stated otherwise (somebody else tagged in the comments or some such). So, if there are documentation issues that have corresponding Airnode issues (you can see that in the description) it's okay for them to not have anybody assigned, somebody will be assigned either on the planning call or somebody will take both from the TODO column.
Does it make sense?

@wkande
Copy link
Member

wkande commented Dec 1, 2022

@aTeoke and @amarthadan

To-date nothing has been done on this issue, I think. The docs still use the field stage in both v0.9 and v0.10. Did this not happen? If it was changed can the developer follow-up with the changes to the docs or at least educate me on the change (in detail) so I can help?

@amarthadan
Copy link
Contributor Author

We've decided against it in the end. So, it wasn't implemented. The main issue was closed but the documentation one was forgotten. Sorry about that. Closing.

@amarthadan amarthadan closed this as not planned Won't fix, can't repro, duplicate, stale Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants