Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix aws.env containing quotation marks causing problems #1205

Closed
amarthadan opened this issue Jun 13, 2022 · 3 comments · Fixed by #1328
Closed

Fix aws.env containing quotation marks causing problems #1205

amarthadan opened this issue Jun 13, 2022 · 3 comments · Fixed by #1328
Assignees
@martinkolenic
Labels
needs documentation
Milestone
0.8.0

Comments

@amarthadan
Copy link
Contributor

JIRA issue discussion
@amarthadan amarthadan added this to the 0.8.0 milestone Jun 13, 2022
@amarthadan amarthadan mentioned this issue Jun 13, 2022
Closed
@amarthadan amarthadan mentioned this issue Jun 29, 2022
Closed
@vponline vponline mentioned this issue Jul 12, 2022
Merged
@amarthadan amarthadan mentioned this issue Jul 13, 2022
Merged
@amarthadan amarthadan assigned martinkolenic and unassigned vponline Jul 13, 2022
@martinkolenic
Copy link
Contributor

martinkolenic commented Jul 13, 2022 •
edited
Loading

Hi @vponline, what is the expected behaviour when I do have quotation marks in aws.env? Thanks.

@vponline
Copy link
Contributor

@kolenic-martin The deloyment and removal should now work with double quotes included, e.g.

AWS_ACCESS_KEY_ID="AKIA...."

@martinkolenic
Copy link
Contributor

Hi @vponline, thanks. I've just finished testing the deployment and removal with the quotation marks in aws.env and I can now confirm it works.

@amarthadan amarthadan mentioned this issue Aug 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martinkolenic martinkolenic

Labels
needs documentation
Projects
None yet
Milestone
0.8.0
Development

Successfully merging a pull request may close this issue.

Mount aws.env to deployer docker image and export with entrypoint api3dao/airnode
3 participants
@martinkolenic @amarthadan @vponline