fix(state): skip Content-Location header for GET requests #6901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinceAmstoutz
changed the title
vinceAmstoutz
changed the title
vinceAmstoutz
changed the title
vinceAmstoutz
changed the title
|
For information @soyuka, php-cs-fixer job is solved in #6902 and other CI failed jobs in this commit. |
dunglas
approved these changes
Jan 9, 2025
soyuka
reviewed
Jan 9, 2025
vinceAmstoutz
force-pushed
the
fix/no-content-location-on-get
branch
2 times, most recently
from
25c7fa4 to
a162646
Compare
soyuka
reviewed
Jan 9, 2025
vinceAmstoutz
force-pushed
the
fix/no-content-location-on-get
branch
from
ad0de1c to
0a3fdf1
Compare
Avoids adding a redundant `Content-Location` header in GET responses, which can cause unnecessary complications, such as issues with temporary or preview resources lacking an ID. While this behavior complies with the HTTP specification (RFC 9110), it is unnecessary and potentially problematic.
vinceAmstoutz
force-pushed
the
fix/no-content-location-on-get
branch
from
0a3fdf1 to
6d74cd2
Compare
dunglas
approved these changes
Jan 13, 2025
soyuka
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4.0Eliminates the unnecessary
Content-Locationheader from GET responses to prevent potential issues, such as with temporary or preview resources lacking an ID.While compliant with RFC 9110, this header is redundant and not required. For more details, refer to #6750.