fix(laravel): disable GraphQL by default and fix provider #6585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
force-pushed
the
fix/laravel-graphql
branch
from
97306f2 to
749138a
Compare
dunglas
commented
Sep 5, 2024
Comment on lines
+1095
to
+1099
| if ($config->get('api-platform.graphql.enabled')) { | ||
| $fieldsBuilder = $this->app->make(FieldsBuilderEnumInterface::class); | ||
| $typeBuilder = $this->app->make(ContextAwareTypeBuilderInterface::class); | ||
| $typeBuilder->setFieldsBuilderLocator(new ServiceLocator(['api_platform.graphql.fields_builder' => $fieldsBuilder])); | ||
| } |
There was a problem hiding this comment.
Is this intended @soyuka? it looks like $typeBuilderis unused. Is it maybe a rest of something?
There was a problem hiding this comment.
we're in the boot method, this is to handle a circular dependency between the FieldsBuilder and theTypeBuilder of graphql...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents a crash when GraphQL isn't installed, which is the default.