fix parameters extractor in openapi with yaml #5487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jorissae
commented
Mar 22, 2023
jorissae
commented
| Q | A |
|---|---|
| Branch? | 3.1 |
| Tickets | #5484 |
| License | MIT |
jorissae
force-pushed
the
fix-yaml-openapi-extractor-parameters
branch
2 times, most recently
from
56e233d to
e3f89ef
Compare
|
@vincentchalamon I added the tests and it's well covered I don't know why it's still marked as not covered |
vincentchalamon
approved these changes
Mar 23, 2023
soyuka
requested changes
Mar 23, 2023
jorissae
force-pushed
the
fix-yaml-openapi-extractor-parameters
branch
from
a283289 to
66dc30a
Compare
soyuka
approved these changes
Mar 28, 2023
jorissae
force-pushed
the
fix-yaml-openapi-extractor-parameters
branch
from
66dc30a to
d0b617c
Compare
|
many thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.