Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graphql): link relations requires the property #5169

Merged
merged 9 commits into from
Dec 13, 2022

Conversation

develth
Copy link
Contributor

@develth develth commented Nov 7, 2022

Q A
Branch? 3.0
Tickets #4613 (comment) & #4613 (comment) & #4931 (PR)
License MIT
Doc PR api-platform/docs#..

Extend from #4931 to provide tests

@develth
Copy link
Contributor Author

develth commented Nov 8, 2022

force push because of f*kd up commit messages :/

@develth
Copy link
Contributor Author

develth commented Nov 8, 2022

hey @alanpoulain

Just updated the tests to use an separate model.
If you run the test without the changes in src/, you see what currently is not working / mixing up

@soyuka soyuka requested a review from alanpoulain December 10, 2022 10:02
@alanpoulain alanpoulain force-pushed the fix/graphql-query-relations branch 3 times, most recently from 3e1d978 to dc88545 Compare December 13, 2022 14:37
@alanpoulain alanpoulain marked this pull request as ready for review December 13, 2022 14:51
@alanpoulain alanpoulain force-pushed the fix/graphql-query-relations branch from dc88545 to f2f1da2 Compare December 13, 2022 14:57
@alanpoulain alanpoulain merged commit 3d3c2c7 into api-platform:3.0 Dec 13, 2022
@alanpoulain
Copy link
Member

Thank you @develth and @webda2l.

@develth
Copy link
Contributor Author

develth commented Dec 13, 2022

props go to @webda2l - i just wrote some tests

@webda2l
Copy link
Contributor

webda2l commented Dec 14, 2022

@develth team work ;)
@alanpoulain nice trick with the # :) I will soon retry to get on the official repo instead my fork.

@develth
Copy link
Contributor Author

develth commented Dec 14, 2022

@alanpoulain nice trick with the # :) I will soon retry to get on the official repo instead my fork.

i use cweagans/composer-patches for that - no need to fork and just use patches to solve temporary the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants