feat(openapi): add backed enum support #5120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpoulain
force-pushed
the
feat/openapi-enum-support
branch
2 times, most recently
from
128783c to
f4c541a
Compare
alanpoulain
force-pushed
the
feat/openapi-enum-support
branch
from
f4c541a to
6cf2146
Compare
soyuka
reviewed
Nov 9, 2022
| $enumType = null; | ||
| if (null !== $enumClass = $metadata instanceof MongoDbClassMetadata ? $metadata->getFieldMapping($property)['enumType'] ?? null : null) { | ||
| $enumType = new Type(Type::BUILTIN_TYPE_OBJECT, $nullable, $enumClass); | ||
| } | ||
|
|
||
| switch ($typeOfField) { |
| @@ -92,6 +92,10 @@ public function getTypes($class, $property, array $context = []): ?array | |||
| if ($metadata->hasField($property)) { | |||
| $typeOfField = $metadata->getTypeOfField($property); | |||
| $nullable = $metadata instanceof MongoDbClassMetadata && $metadata->isNullable($property); | |||
| $enumType = null; | |||
| if (null !== $enumClass = $metadata instanceof MongoDbClassMetadata ? $metadata->getFieldMapping($property)['enumType'] ?? null : null) { | |||
There was a problem hiding this comment.
we try to avoid multiple conditions in an if
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #4857.
Partially fixes #2254.