fix(state): improve DX around the generic ObjectProvider
#5051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
force-pushed
the
generic-obj-provider
branch
5 times, most recently
from
6470195 to
432fee3
Compare
chalasr
force-pushed
the
generic-obj-provider
branch
from
432fee3 to
20b2180
Compare
|
thanks, phpstan error not related. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #5039.
While using
ReflectionClass::newInstanceWithoutConstructor()avoids any instantiation issue, it may lead to hard-to-debug situations in case the resource at hand has mandatory constructor parameters or if it initializes some state (basically any logic).This patch makes sure that the constructor is called, while catching any potential instantiation error and turning it into a meaningful - developer-friendly error.